Skip to content

Conversation

@sergeibbb
Copy link
Member

Description

Reverts plain repo icon

This PR fixes #4387 that keeps an element expanded because it holds focus after a click.

The previous solution f31b51a reverted implementation of one of requirements of #4332, where it required to replace integration icon with a simple repo icon, and another regression has been noticed:
image

Fixes collapsing of focused

Therefore I reverted it and applied the ignorance of the :focus-within property by breadcrumbs in active-work element without affecting breadcrumbs behavior in other places of GitLens. I did it by adding a new optional property that can customize this property: whether the :focus-within should be considered or ignored on collapsing.

Fixes width movement on hover

Also it solves another issue that has been recently reported:

work-item-breadcrumb-hover.mov

I didn't do anything special for that, just cannot reproduce it after my changes.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Adds an `ignoreFocusWithin` property to the breadcrumb item that lets it to collapse even when it holds the focus after a click. This allows to prevent the breadcrumb item from expanding when focused.
(#4387, #4402)
@sergeibbb sergeibbb force-pushed the 4387-fix-hover-animation branch from e723dbb to 88f6f90 Compare June 16, 2025 18:11
@sergeibbb sergeibbb requested a review from axosoft-ramint June 16, 2025 18:12
@sergeibbb sergeibbb closed this Jun 17, 2025
@sergeibbb sergeibbb deleted the 4387-fix-hover-animation branch June 17, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking the repo icon to collapse the repo name on the current work item section of home doesn't work

1 participant