Skip to content

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jul 9, 2025

Fixes warnings like these:

▲ [WARNING] This case clause will never be evaluated because it duplicates an earlier case clause [duplicate-case]

    src/webviews/plus/graph/graphWebview.utils.ts:173:7:
      173 │     case 'github' satisfies Unbrand<GkProviderId>:

that started happening during pnpm run test here: f7facea (#4468)

Probably that started happening because graphWebview.utils.ts appeared in the test assembly for the first time, through a new chain of imports.

However, it does not appear on the main build task. Therefore I decided to modify building properties of tests, so the compiler become tolerant to these expressions as well as the main build.


Also fixes prettier that was broken in ff3858f (#4473)

@sergeibbb sergeibbb marked this pull request as draft July 9, 2025 11:01
@sergeibbb sergeibbb changed the title Fixes compilation warnings: consolidates redundant cases Silences duplicate-case warnings in test builds Jul 9, 2025
@sergeibbb sergeibbb force-pushed the chore/fix-switch-case-warnings branch from 6e57ab3 to 9a9d48d Compare July 9, 2025 13:28
sergeibbb added a commit that referenced this pull request Jul 9, 2025
@sergeibbb sergeibbb force-pushed the chore/fix-switch-case-warnings branch from a6edacf to c3c0d52 Compare July 9, 2025 13:38
@sergeibbb sergeibbb marked this pull request as ready for review July 9, 2025 13:38
@sergeibbb sergeibbb merged commit 755ef07 into main Jul 9, 2025
4 checks passed
sergeibbb added a commit that referenced this pull request Jul 9, 2025
@sergeibbb sergeibbb deleted the chore/fix-switch-case-warnings branch July 9, 2025 13:40
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant