Skip to content

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Sep 3, 2025

Description

  • Fixes e2e tests by supporting for type change file status in Git parsing.
  • Also it enforces code formatting check before running tests, because it frequently gets broken in main.
  • And I suggest that we should run it on main, because it's often get broken when someone pushes right to main without a PR.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb requested a review from eamodio September 3, 2025 12:58
sergeibbb added a commit that referenced this pull request Sep 3, 2025
because it frequently gets broken in main.
(#4563)
@sergeibbb sergeibbb self-assigned this Sep 3, 2025
sergeibbb added a commit that referenced this pull request Sep 3, 2025
because otherwise they often get when a developer pushes to main without a PR.

Ensures that unit tests are executed automatically when changes are pushed to the main branch, improving test coverage and early detection of issues in the primary codebase.

(#4563)
@sergeibbb sergeibbb requested a review from d13 September 11, 2025 16:19
@justinrobots justinrobots added this to the 17.6 milestone Sep 16, 2025
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

My only concern is that I don't have a good way to really test this change type in order to understand the ripple effect of this change.

because it frequently gets broken in main.
(#4563)
because otherwise they often get when a developer pushes to main without a PR.

Ensures that unit tests are executed automatically when changes are pushed to the main branch, improving test coverage and early detection of issues in the primary codebase.

(#4563)
@sergeibbb
Copy link
Member Author

@d13

My only concern is that I don't have a good way to really test this change type in order to understand the ripple effect of this change.

The difference in the code takes effect when file permissions are changed, e.g. chmod u+x script.sh. The related function is used in Commit Composer. The result looks pretty nice, identical to how it looks in master:

image

Another change is in testing. I think that the existing behavior is correct and the unit test needed to be modified:

image

@sergeibbb sergeibbb merged commit ee6eb93 into main Sep 29, 2025
3 checks passed
sergeibbb added a commit that referenced this pull request Sep 29, 2025
because it frequently gets broken in main.
(#4563)
@sergeibbb sergeibbb deleted the fix-e2e-tests branch September 29, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants