Skip to content

Conversation

axosoft-ramint
Copy link
Contributor

This is to prevent entire diffs being passed back from the app via IPC for commands like auto-compose, generate commit message, finish and commit, etc.

One thing I noticed is that the diff contents have artifacts from serialization and this can break the safety checks and the diff hashes, causing false positive errors on safety state. Also, it seems expensive to pass massive payloads like this over IPC for these ops anyway.

We still need to pass the hunks with their diffs through to the app for rendering content, but that should be the only purpose of the hunk contents in app state.

Lots of regression risk here i.e. with undo/reset history, reload, all AI ops, finish & commit, etc. so lots of testing required.

eamodio and others added 4 commits September 10, 2025 23:31
@axosoft-ramint
Copy link
Contributor Author

@d13 @eamodio This is ready for review - I'm marking as draft just so we don't accidentally merge it with the current release.

It should be in a follow-up patch because there's high regression risk and it needs extensive testing.

@axosoft-ramint
Copy link
Contributor Author

Wrong branch targets. Reopening as a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants