Skip to content

Conversation

axosoft-ramint
Copy link
Contributor

Repro steps:

  1. Open commit composer
  2. Try to generate commit message with no provider selected and github copilot disabled as an extension (so no vscode ai provider available) and not logged into GK (so no GK provider available as fallback)
  3. Cancel or escape at any point in the flow (choosing a provider, choosing a model, sign in prompt for GK provider)

Expect for composer to treat it as a cancellation. See an error instead.

Note: these changes affect logic being used in many places because they touch core AI provider service paths, so lots of possible regressions to test:

  1. AI provider selection in other places should work as before
  2. AI commit message generation in other places as well as other AI ops should be spot-checked

Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axosoft-ramint axosoft-ramint merged commit 7374dff into main Oct 3, 2025
2 of 3 checks passed
@axosoft-ramint axosoft-ramint deleted the bug/ai-cancellation-shows-as-error branch October 3, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants