Skip to content

Add missing fields to ApprovalRule #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmini merged 2 commits into from
Jul 27, 2025
Merged

Add missing fields to ApprovalRule #1265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb41bb6
Add protectedBranches to ApprovalRule
christophbrill-cgmcom Jul 21, 2025
d5f67bb
Update example and add missing fields
jmini Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions gitlab4j-models/src/main/java/org/gitlab4j/api/models/ApprovalRule.java
View file
Open in desktop
Copy link
Collaborator

@jmini jmini Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the corresponding json file used in the test TestGitLabApiBeans:
https://github.com/gitlab4j/gitlab4j-api/blob/39cbdc75efaf441e8f4430677749673fd3a3090f/gitlab4j-models/src/test/resources/org/gitlab4j/models/approval-rule.json

Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public class ApprovalRule implements Serializable {
private Boolean containsHiddenGroups;
private List<User> approvedBy;
private Boolean approved;
private List<ProtectedBranch> protectedBranches;

public Long getId() {
return id;
Expand Down Expand Up @@ -108,6 +109,14 @@ public void setApproved(Boolean approved) {
this.approved = approved;
}

public List<ProtectedBranch> getProtectedBranches() {
return protectedBranches;
}

public void setProtectedBranches(List<ProtectedBranch> protectedBranches) {
this.protectedBranches = protectedBranches;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
Expand Down
Loading