Skip to content

Commit 12ae791

Browse files
johanngesJohannes Gesenhues
andauthored
Added missing scopes to deploy token (#769)
* added missing scopes to gitlab deploy token * removed write_repository, because it is not allowed Co-authored-by: Johannes Gesenhues <[email protected]>
1 parent e89922e commit 12ae791

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

gitlab/resource_gitlab_deploy_token.go

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,15 @@ func resourceGitlabDeployToken() *schema.Resource {
5555
Required: true,
5656
ForceNew: true,
5757
Elem: &schema.Schema{
58-
Type: schema.TypeString,
59-
ValidateFunc: validation.StringInSlice([]string{"read_registry", "read_repository"}, false),
58+
Type: schema.TypeString,
59+
ValidateFunc: validation.StringInSlice(
60+
[]string{
61+
"read_registry",
62+
"read_repository",
63+
"read_package_registry",
64+
"write_registry",
65+
"write_package_registry",
66+
}, false),
6067
},
6168
},
6269

@@ -169,12 +176,17 @@ func resourceGitlabDeployTokenRead(d *schema.ResourceData, meta interface{}) err
169176
}
170177

171178
for _, scope := range token.Scopes {
172-
if scope == "read_repository" {
179+
switch scope {
180+
case "read_repository":
173181
d.Set("scopes.read_repository", true)
174-
}
175-
176-
if scope == "read_registry" {
182+
case "read_registry":
177183
d.Set("scopes.read_registry", true)
184+
case "read_package_registry":
185+
d.Set("scopes.read_package_registry", true)
186+
case "write_registry":
187+
d.Set("scopes.write_registry", true)
188+
case "write_package_registry":
189+
d.Set("scopes.write_package_registry", true)
178190
}
179191
}
180192
}

gitlab/resource_gitlab_deploy_token_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,9 @@ resource "gitlab_deploy_token" "foo" {
161161
scopes = [
162162
"read_registry",
163163
"read_repository",
164+
"read_package_registry",
165+
"write_registry",
166+
"write_package_registry",
164167
]
165168
}
166169
`, rInt, rInt)

0 commit comments

Comments
 (0)