CI: Use golangci-lint to run gofmt; remove redundant errcheck script

Author: armsnyder

.github/workflows/unit-tests.yml

@@ -9,7 +9,7 @@ jobs:
       matrix:
         go: [1.15, 1.16]
         os: [ubuntu-latest, macos-latest, windows-latest]
-        make_target: [test, vet]
+        make_target: [test]
 
     steps:
     - name: Set up Go

.golangci.yml

@@ -1,3 +1,10 @@
+# https://golangci-lint.run/usage/configuration/
+
 linters-settings:
   errcheck:
     exclude: errcheck_excludes.txt
+
+linters:
+  enable:
+    - gofmt
+    - govet

GNUmakefile

@@ -10,10 +10,10 @@ endif
 
 default: build
 
-build: fmtcheck
+build:
 	go install
 
-test: fmtcheck
+test:
 	go test -i $(TEST) || exit 1
 	echo $(TEST) | \
 		xargs -t -n4 go test $(TESTARGS) -timeout=30s -parallel=4
@@ -25,7 +25,7 @@ testacc-up:
 testacc-down:
 	docker-compose down
 
-testacc: fmtcheck
+testacc:
 	TF_ACC=1 GITLAB_TOKEN=$(GITLAB_TOKEN) GITLAB_BASE_URL=$(GITLAB_BASE_URL) go test -v $(TEST) $(TESTARGS) -timeout 40m
 
 vet:
@@ -40,15 +40,9 @@ vet:
 fmt:
 	gofmt -w $(GOFMT_FILES)
 
-fmtcheck:
-	@sh -c "'$(CURDIR)/scripts/gofmtcheck.sh'"
-
-errcheck:
-	@sh -c "'$(CURDIR)/scripts/errcheck.sh'"
-
 tfproviderlint:
 	go run github.com/bflad/tfproviderlint/cmd/tfproviderlintx \
 	-XAT001=false -XR003=false -XR005=false -XS001=false -XS002=false \
 	./...
 
-.PHONY: default build test testacc-up testacc-down testacc vet fmt fmtcheck errcheck tfproviderlint
+.PHONY: default build test testacc-up testacc-down testacc vet fmt tfproviderlint