Skip to content

Add support for empty repos in GL #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Add support for empty repos in GL #184

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b9e6db
Add support for empty repos in GL
filiptronicek Jan 27, 2025
b3fdc65
Fix tests
filiptronicek Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/button/button-contributions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,13 @@ export const buttonContributions: ButtonContributionParams[] = [
},
],
},
{
id: "gl-repo-empty",
exampleUrls: ["https://gitlab.com/filiptronicek/empty"],
selector: `xpath://*[@id="js-project-show-empty-page"]/div[1]/div[1]/div[2]`,
containerElement: { type: "div", props: { marginLeft: "8px" } },
application: "gitlab",
},
{
id: "gl-file",
exampleUrls: [
Expand Down Expand Up @@ -412,7 +419,8 @@ export const buttonContributions: ButtonContributionParams[] = [
],
selector: 'xpath://*[@id="main"]/div/div/div[1]/div/div/div/div[1]/div/div[2]/div/div[2]/div/div', // grandparent div of the "Request changes" and "Approve" buttons
containerElement: createElement("div", {}),
insertBefore: 'xpath:(//*[@id="main"]/div/div/div[1]/div/div/div/div[1]/div/div[2]/div/div[2]/div/div/div)[last()]', // note the [last()] to insert before the last child (the kebab menu)
insertBefore:
'xpath:(//*[@id="main"]/div/div/div[1]/div/div/div/div[1]/div/div[2]/div/div[2]/div/div/div)[last()]', // note the [last()] to insert before the last child (the kebab menu)
application: "bitbucket",
},
{
Expand Down
3 changes: 3 additions & 0 deletions src/contents/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ class ButtonContributionManager {
return this.buttons.get(this.getContainerId(this.active.contribution));
}

/**
* Checks if the contribution applies to the current page.
*/
private isActive(contrib: ButtonContributionParams) {
if (typeof contrib.match === "function" && !contrib.match()) {
return false;
Expand Down
12 changes: 10 additions & 2 deletions test/src/button-contributions-copy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,13 @@ export const buttonContributions: ButtonContributionParams[] = [
},
],
},
{
id: "gl-repo-empty",
exampleUrls: ["https://gitlab.com/filiptronicek/empty"],
selector: `xpath://*[@id="js-project-show-empty-page"]/div[1]/div[1]/div[2]`,
containerElement: { type: "div", props: { marginLeft: "8px" } },
application: "gitlab",
},
{
id: "gl-file",
exampleUrls: [
Expand Down Expand Up @@ -410,9 +417,10 @@ export const buttonContributions: ButtonContributionParams[] = [
exampleUrls: [
// "https://bitbucket.org/efftinge/browser-extension-test/pull-requests/1"
],
selector: 'xpath://*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div', // grandparent div of the "Request changes" and "Approve" buttons
selector: 'xpath://*[@id="main"]/div/div/div[1]/div/div/div/div[1]/div/div[2]/div/div[2]/div/div', // grandparent div of the "Request changes" and "Approve" buttons
containerElement: createElement("div", {}),
insertBefore: 'xpath:(//*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div/div)[last()]', // note the [last()] to insert before the last child (the kebab menu)
insertBefore:
'xpath:(//*[@id="main"]/div/div/div[1]/div/div/div/div[1]/div/div[2]/div/div[2]/div/div/div)[last()]', // note the [last()] to insert before the last child (the kebab menu)
application: "bitbucket",
},
{
Expand Down
Loading