Skip to content

Fix selectors for new GitHub issue design #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix selectors for new GitHub issue design #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ce965a
Fix selectors for new GitHub issue design
filiptronicek Feb 11, 2025
ab737cc
Fix tests and use puppeteer new headless mode
filiptronicek Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/button/button-contributions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export interface ButtonContributionParams {
/**
* Additional class names that should be added to the elements.
*/
additionalClassNames?: ("secondary" | "medium" | "left-align-menu")[];
additionalClassNames?: ("secondary" | "medium" | "left-align-menu" | "tall")[];

/**
* A selector that is used to insert the button before a specific element.
Expand Down Expand Up @@ -301,7 +301,7 @@ export const buttonContributions: ButtonContributionParams[] = [
},

{
id: "gh-issues",
id: "gh-issue",
exampleUrls: ["https://github.com/svenefftinge/browser-extension-test/issues/1"],
selector: "#partial-discussion-header > div.gh-header-show > div > div",
containerElement: createElement("div", {
Expand All @@ -319,7 +319,17 @@ export const buttonContributions: ButtonContributionParams[] = [
],
},
{
id: "gh-pulls",
id: "gh-issue-new", // this isn't referring to "new issue", but to new "issue"
exampleUrls: ["https://github.com/svenefftinge/browser-extension-test/issues/1"],
selector: `xpath://*[@id="js-repo-pjax-container"]/react-app/div/div/div/div/div[1]/div/div/div[3]/div`,
containerElement: createElement("div", {}),
insertBefore: `xpath://*[@id="js-repo-pjax-container"]/react-app/div/div/div/div/div[1]/div/div/div[3]/div/div`,
application: "github",
// we need to make the button higher: the buttons here use 2rem instead of 1.75rem
additionalClassNames: ["tall"],
},
{
id: "gh-pull",
exampleUrls: ["https://github.com/svenefftinge/browser-extension-test/pull/2"],
selector: "#partial-discussion-header > div.gh-header-show > div > div",
containerElement: createElement("div", {
Expand Down
4 changes: 4 additions & 0 deletions src/button/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,10 @@
--dropdown-box-shadow: var(--shadow-floating-large, var(--color-shadow-large));
}

.github.tall {
--primary-height: var(--control-medium-size, 2rem);
}

.github .chevron-icon {
padding: 3px;
}
Expand Down
16 changes: 13 additions & 3 deletions test/src/button-contributions-copy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export interface ButtonContributionParams {
/**
* Additional class names that should be added to the elements.
*/
additionalClassNames?: ("secondary" | "medium" | "left-align-menu")[];
additionalClassNames?: ("secondary" | "medium" | "left-align-menu" | "tall")[];

/**
* A selector that is used to insert the button before a specific element.
Expand Down Expand Up @@ -301,7 +301,7 @@ export const buttonContributions: ButtonContributionParams[] = [
},

{
id: "gh-issues",
id: "gh-issue",
exampleUrls: ["https://github.com/svenefftinge/browser-extension-test/issues/1"],
selector: "#partial-discussion-header > div.gh-header-show > div > div",
containerElement: createElement("div", {
Expand All @@ -319,7 +319,17 @@ export const buttonContributions: ButtonContributionParams[] = [
],
},
{
id: "gh-pulls",
id: "gh-issue-new", // this isn't referring to "new issue", but to new "issue"
exampleUrls: ["https://github.com/svenefftinge/browser-extension-test/issues/1"],
selector: `xpath://*[@id="js-repo-pjax-container"]/react-app/div/div/div/div/div[1]/div/div/div[3]/div`,
containerElement: createElement("div", {}),
insertBefore: `xpath://*[@id="js-repo-pjax-container"]/react-app/div/div/div/div/div[1]/div/div/div[3]/div/div`,
application: "github",
// we need to make the button higher: the buttons here use 2rem instead of 1.75rem
additionalClassNames: ["tall"],
},
{
id: "gh-pull",
exampleUrls: ["https://github.com/svenefftinge/browser-extension-test/pull/2"],
selector: "#partial-discussion-header > div.gh-header-show > div > div",
containerElement: createElement("div", {
Expand Down
6 changes: 2 additions & 4 deletions test/src/button-contributions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ describe("Platform match tests", function () {

before(async function () {
browser = await puppeteer.launch({
headless: true,
browser: "chrome",
headless: "new",
});
page = await browser.newPage();
});
Expand Down Expand Up @@ -66,8 +65,7 @@ describe("Query Selector Tests", function () {

before(async function () {
browser = await puppeteer.launch({
headless: true,
browser: "chrome",
headless: "new",
});
page = await browser.newPage();
});
Expand Down
Loading