Merge pull request moby#5182 from tonistiigi/internal-syscall-err

errdefs: detect certain sycall errors as internal

Author: crazy-max

errdefs/errdefs.go

@@ -0,0 +1,59 @@
+package errdefs
+
+import (
+	"errors"
+	"syscall"
+)
+
+type internalErr struct {
+	error
+}
+
+func (internalErr) System() {}
+
+func (err internalErr) Unwrap() error {
+	return err.error
+}
+
+type system interface {
+	System()
+}
+
+var _ system = internalErr{}
+
+func Internal(err error) error {
+	if err == nil {
+		return nil
+	}
+	return internalErr{err}
+}
+
+func IsInternal(err error) bool {
+	var s system
+	if errors.As(err, &s) {
+		return true
+	}
+
+	var errno syscall.Errno
+	if errors.As(err, &errno) {
+		if _, ok := isInternalSyscall(errno); ok {
+			return true
+		}
+	}
+	return false
+}
+
+func IsResourceExhausted(err error) bool {
+	var errno syscall.Errno
+	if errors.As(err, &errno) {
+		if v, ok := isInternalSyscall(errno); ok && v {
+			return v
+		}
+	}
+	return false
+}
+
+func isInternalSyscall(err syscall.Errno) (bool, bool) {
+	v, ok := syscallErrors()[err]
+	return v, ok
+}

errdefs/internal.go

@@ -0,0 +1,23 @@
+//go:build linux
+// +build linux
+
+package errdefs
+
+import (
+	"syscall"
+
+	"golang.org/x/sys/unix"
+)
+
+// syscallErrors returns a map of syscall errors that are considered internal.
+// value is true if the error is of type resource exhaustion, false otherwise.
+func syscallErrors() map[syscall.Errno]bool {
+	return map[syscall.Errno]bool{
+		unix.EIO:             false, // I/O error
+		unix.ENOMEM:          true,  // Out of memory
+		unix.EFAULT:          false, // Bad address
+		unix.ENOSPC:          true,  // No space left on device
+		unix.ENOTRECOVERABLE: false, // State not recoverable
+		unix.EHWPOISON:       false, // Memory page has hardware error
+	}
+}

errdefs/internal_linux.go

@@ -0,0 +1,10 @@
+//go:build !linux
+// +build !linux
+
+package errdefs
+
+import "syscall"
+
+func syscallErrors() map[syscall.Errno]bool {
+	return nil
+}

errdefs/internal_nolinux.go

@@ -96,6 +96,9 @@ func withDetails(ctx context.Context, s *status.Status, details ...proto.Message
 
 func Code(err error) codes.Code {
 	if errdefs.IsInternal(err) {
+		if errdefs.IsResourceExhausted(err) {
+			return codes.ResourceExhausted
+		}
 		return codes.Internal
 	}