Skip to content

Commit 426377a

Browse files
committed
reject compose file using secrets|configs.driver or template_driver
Signed-off-by: Nicolas De Loof <[email protected]>
1 parent 43c3f54 commit 426377a

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

pkg/compose/create.go

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"bytes"
2121
"context"
2222
"encoding/json"
23+
"errors"
2324
"fmt"
2425
"os"
2526
"path"
@@ -804,6 +805,13 @@ func buildContainerConfigMounts(p types.Project, s types.ServiceConfig) ([]mount
804805
return nil, fmt.Errorf("unsupported external config %s", definedConfig.Name)
805806
}
806807

808+
if definedConfig.Driver != "" {
809+
return nil, errors.New("Docker Compose does not support configs.*.driver")
810+
}
811+
if definedConfig.TemplateDriver != "" {
812+
return nil, errors.New("Docker Compose does not support configs.*.template_driver")
813+
}
814+
807815
bindMount, err := buildMount(p, types.ServiceVolumeConfig{
808816
Type: types.VolumeTypeBind,
809817
Source: definedConfig.File,
@@ -843,6 +851,13 @@ func buildContainerSecretMounts(p types.Project, s types.ServiceConfig) ([]mount
843851
return nil, fmt.Errorf("unsupported external secret %s", definedSecret.Name)
844852
}
845853

854+
if definedSecret.Driver != "" {
855+
return nil, errors.New("Docker Compose does not support secrets.*.driver")
856+
}
857+
if definedSecret.TemplateDriver != "" {
858+
return nil, errors.New("Docker Compose does not support secrets.*.template_driver")
859+
}
860+
846861
if definedSecret.Environment != "" {
847862
continue
848863
}

0 commit comments

Comments
 (0)