Improve supervisor failed reading bob log error

Author: filiptronicek

components/dashboard/src/workspaces/CreateWorkspacePage.tsx

@@ -552,9 +552,9 @@ export function CreateWorkspacePage() {
                                 <span className="text-sm">{warningIde}</span>
                             </Alert>
                         )}
-                        {workspaceContext.data?.data.metadata?.warnings.map((w) => (
-                            <Alert type="warning" key={w}>
-                                <span className="text-sm">{w}</span>
+                        {workspaceContext.data?.data.metadata?.warnings.map((warning) => (
+                            <Alert type="warning" key={warning}>
+                                <span className="text-sm">{warning}</span>
                             </Alert>
                         )) ?? []}
 

components/supervisor/pkg/supervisor/supervisor.go

@@ -1599,19 +1599,21 @@ func stopWhenTasksAreDone(wg *sync.WaitGroup, cfg *Config, shutdown chan Shutdow
 
 	success := <-successChan
 	if success.Failed() {
-		var msg []byte
+		var msg string
 		if cfg.isImageBuild() {
 			logFromFile, err := os.ReadFile("/workspace/.gitpod/bob.log")
+			debugMsg := "Debug this using `gp validate` (visit https://www.gitpod.io/docs/configure/workspaces#validate-your-gitpod-configuration) to learn more"
 			if err != nil {
-				msg = []byte("err while reading bob.log" + err.Error())
+				log.WithError(err).Error("err while reading bob.log")
+				msg = fmt.Sprintf("image build failed: %s. %s", string(success), debugMsg)
 			} else {
-				msg = []byte("image build failed: " + string(logFromFile) + ". Debug this using `gp validate` (visit https://www.gitpod.io/docs/configure/workspaces#validate-your-gitpod-configuration) to learn more")
+				msg = fmt.Sprintf("image build failed: %s. %s", string(logFromFile), debugMsg)
 			}
 		} else {
-			msg = []byte("headless task failed: " + string(success))
+			msg = fmt.Sprintf("headless task failed: %s", string(success))
 		}
 		// we signal task failure via kubernetes termination log
-		err := os.WriteFile("/dev/termination-log", msg, 0o644)
+		err := os.WriteFile("/dev/termination-log", []byte(msg), 0o644)
 		if err != nil {
 			log.WithError(err).Error("err while writing termination log")
 		}