Skip to content

Hashed user ID cookie improvements #20232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2024
Merged

Hashed user ID cookie improvements #20232

merged 3 commits into from
Sep 19, 2024

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Sep 18, 2024 •
edited by github-actions bot
Loading

Description

This PR introduces two changes:

  • Forces JWT cookie verification after a set time after page load (20 seconds)
  • Issues the hashed user ID cookie after login, so that we make its use consistent with our regular auth cookie lifecycle

Related Issue(s)

Fixes https://gitpod.slack.com/archives/C071G5TTS49/p1726677726256909?thread_ts=1726648214.862269&cid=C071G5TTS49

Test today at https://ft-initial835bbe244e.preview.gitpod-dev.com/workspaces

  • /werft with-preview
  • /werft with-gce-vm

Preview status

Gitpod was successfully deployed to your preview environment.

@filiptronicek filiptronicek marked this pull request as ready for review September 18, 2024 21:02
@filiptronicek filiptronicek requested review from a team as code owners September 18, 2024 21:02
Siddhant-K-code
Siddhant-K-code approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✅

Unable to test it, because preview env. seems to be down!

@Siddhant-K-code
Copy link
Member

Related #20231, #20226

@Siddhant-K-code
Copy link
Member

Recreated the VM & Preview env. is working ✅

@Siddhant-K-code
Copy link
Member

/unhold

@roboquat roboquat merged commit abb191f into main Sep 19, 2024
60 of 71 checks passed
@roboquat roboquat deleted the ft/initial-jwt-cookie-refresh branch September 19, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siddhant-K-code Siddhant-K-code Siddhant-K-code approved these changes

Assignees

No one assigned

Labels

size/S team: team-enterprise team: team-experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filiptronicek @Siddhant-K-code @roboquat