-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Non-project repository starting restrictions #20234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely agree, let's not suggest them when they're restricted.
This is mostly targeted against the Collaborator role, but we made it a bit more flexible. I don't feel like it's not a restriction, the same way you could have a restriction on an expensing system which would force you to have receipts for every expense you want to submit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
One last nit (not-blocker): users restricted can still try to create workspace by copy-paste or browser-extension, and then it will add a failed workspace as well. Maybe we could do permission check before create workspace?



Description
Allow org owners to limit roles which can start workspaces from repositories that have not been imported.
Related Issue(s)
Fixes ENT-816
How to test