Skip to content

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Sep 30, 2024

Description

Include the node name, if available, in workspace failed log entries. This'll help us more easily determine if a single node is poisoned, or if the problem is more wide spread.

Related Issue(s)

Related to https://gitpod.slack.com/archives/C01TNS8EVQT/p1727709074376869

How to test

Try starting a workspace, kill registry-facade while the image is pulling:
image

Observe the log entry contains a node name:
image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@kylos101
Copy link
Contributor Author

kylos101 commented Oct 1, 2024

@nandajavarma can you add a ✅ ?

@geropl we should consider updating code owners.

@roboquat roboquat merged commit ca933cb into main Oct 2, 2024
56 of 58 checks passed
@roboquat roboquat deleted the kylos101/nodename branch October 2, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants