Don't report supervisor_check_ready unless the FF is enabled
#20292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @filiptronicek , I observed trackEvent via a workwspace in this preview (with the flag on and off), but didn't find a trackEvent where the event was
|
|
@kylos101 I found it useful to filter my network events for |
Awesome, thank you for sharing test results. I filtered by trackEvent, and saw other events, but not this one. Does it take a bit for the feature flag value to propagate to the preview? |
|
@kylos101 usually takes about 3-10 minutes at most |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
supervisor_check_ready_retryis disabled, don't report anysupervisor_check_readyevents.Related Issue(s)
Fixes https://gitpod.slack.com/archives/C071G5TTS49/p1728468748822559
How to test
You can try opening a workspace on https://ft-limit-sb2f59260e6.preview.gitpod-dev.com/workspaces and inspecting the network tab for outgoing
trackEventrequests./hold