[gha] update gateway EAP plugin to use build instead of version
#20313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylos101
reviewed
Oct 23, 2024
| productCode: "GW", | ||
| productType: "eap,rc,release", | ||
| usePlatformVersionType: "version", | ||
| usePlatformVersionType: "build", |
There was a problem hiding this comment.
I see we are already using this:
So it makes sense to be on build. Thanks for the explanation below!
kylos101
approved these changes
Oct 23, 2024
kylos101
reviewed
Oct 23, 2024
Comment on lines
+40
to
+42
| * - build 243.18137.22 | ||
| * - version 2024.3 | ||
| * - build-snapshot 243.18137-EAP-CANDIDATE-SNAPSHOT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There're some back and forth, I'm not quite sure how they define it but can confirm we need to use
buildfor Gateway Plugin (EAP) nowRelated Issue(s)
Fixes #20301 that it should not use
versionHow to test
No need to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold