Skip to content

[gha] update gateway EAP plugin to use build instead of version #20313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[gha] update gateway EAP plugin to use build instead of version #20313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions components/ide/gha-update-image/lib/jb-helper/jb-gradle-task-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { parseArgs } from "util";

export type TaskInfo = TargetInfo & { id: number; taskName: string };

// Official doc https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html#target-versions-installers:~:text=The%20listing%20of%20all%20present%20installers%20can%20be%20resolved%20with%20updates%20XML%20files%20for%20JetBrains%20IDEs%20and%20Android%20Studio%20as%20well%20as%20by%20executing%20the%20printProductsReleases%20task.
// But use https://data.services.jetbrains.com/products/releases?code=GW&type=eap,rc,release&platform=linux seems better

export const latestBackendPluginGradleTarget: TaskInfo = {
id: 1,
taskName: "Latest Backend Plugin",
Expand All @@ -24,7 +27,7 @@ pluginUntilBuild={{pluginUntilBuild}}
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
# See https://jb.gg/intellij-platform-builds-list for available build versions.
pluginVerifierIdeVersions={{pluginVerifierIdeVersions}}
# Version from "com.jetbrains.intellij.idea" which can be found at https://www.jetbrains.com/intellij-repository/snapshots
# Version from "com.jetbrains.intellij.idea" which can be found at https://www.jetbrains.com/updates/updates.xml or exec \`./gradlew printProductsReleases\`
platformVersion={{platformVersion}}
`,
};
Expand All @@ -35,7 +38,7 @@ export const latestGatewayPluginGradleTarget: TaskInfo = {
productId: "gateway",
productCode: "GW",
productType: "eap,rc,release",
usePlatformVersionType: "version",
usePlatformVersionType: "build",
Copy link
Contributor

@kylos101 kylos101 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we are already using this:

gitpod/components/ide/jetbrains/gateway-plugin/gradle-latest.properties

Line 11 in babc571

platformVersion=243.18137.22

So it makes sense to be on build. Thanks for the explanation below!

gradlePropertiesPath: path.resolve(
pathToProjectRoot,
"components/ide/jetbrains/gateway-plugin/gradle-latest.properties",
Expand All @@ -48,7 +51,7 @@ pluginUntilBuild={{pluginUntilBuild}}
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
# See https://jb.gg/intellij-platform-builds-list for available build versions.
pluginVerifierIdeVersions={{pluginVerifierIdeVersions}}
# Version from "com.jetbrains.gateway" which can be found at https://www.jetbrains.com/intellij-repository/snapshots
# Version from "com.jetbrains.gateway" which can be found at https://www.jetbrains.com/updates/updates.xml or exec \`./gradlew printProductsReleases\`
platformVersion={{platformVersion}}
`,
};
Expand All @@ -72,7 +75,7 @@ pluginUntilBuild={{pluginUntilBuild}}
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
# See https://jb.gg/intellij-platform-builds-list for available build versions.
pluginVerifierIdeVersions={{pluginVerifierIdeVersions}}
# Version from "com.jetbrains.gateway" which can be found at https://www.jetbrains.com/updates/updates.xml
# Version from "com.jetbrains.gateway" which can be found at https://www.jetbrains.com/updates/updates.xml or exec \`./gradlew printProductsReleases\`
platformVersion={{platformVersion}}
`,
};
Expand Down
6 changes: 6 additions & 0 deletions components/ide/gha-update-image/lib/jb-helper/jb-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ export interface TargetInfo {
* @example eap,rc,release
*/
productType: string;
/**
* Examples value for different type:
* - build 243.18137.22
* - version 2024.3
* - build-snapshot 243.18137-EAP-CANDIDATE-SNAPSHOT
Comment on lines +40 to +42
Copy link
Contributor

@kylos101 kylos101 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

*/
usePlatformVersionType: "build" | "version" | "build-snapshot";
gradlePropertiesPath: string;
gradlePropertiesTemplate: string;
Expand Down
Loading