Add AWS re:Invent 2024 notification #20323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/unhold |
kylos101
approved these changes
Oct 28, 2024
Contributor
kylos101
left a comment
kylos101
left a comment
There was a problem hiding this comment.
LGTM
I assume you'll delete https://github.com/gitpod-io/gitpod/pull/20323/files#diff-58105ccfab33625cb400e4404829a34ed24538d6063fb2b762d41006a25a5653R170-R187 after the event, and, no need for long term string constants, hence doing inline.
I'm not sure how to trigger this myself, and assume you did by manually altering your profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a reusable notification factory to standardize creation of dismissible notifications with tracking. This reduces code duplication and makes adding new notifications simpler.
GENERAL_NOTIFICATIONfactory functionRelated Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold