Skip to content

[server] Add more tests around "prebuild selection" #20358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2024
Merged

[server] Add more tests around "prebuild selection" #20358

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
766b421
[server] Extend and fix context parser tests around prebuild discovery
geropl Nov 6, 2024
58ca821
[server] Add more "prebuild selection" tests to ContextService
geropl Nov 12, 2024
b5a3429
review comments
geropl Nov 12, 2024
0c8343b
[server] Fix order of commits in MockRepositoryProvider to be aligned…
geropl Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/server/src/prebuilds/incremental-workspace-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class IncrementalWorkspaceService {
return history;
}

public async findGoodBaseForIncrementalBuild(
public async findBaseForIncrementalWorkspace(
context: CommitContext,
config: WorkspaceConfig,
history: WithCommitHistory,
Expand Down
3 changes: 2 additions & 1 deletion components/server/src/prebuilds/prebuild-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ export class PrebuildManager {
commitHistory: repoHist.commitHistory.slice(0, prebuildInterval),
})),
};
const prebuild = await this.incrementalPrebuildsService.findGoodBaseForIncrementalBuild(
const prebuild = await this.incrementalPrebuildsService.findBaseForIncrementalWorkspace(
context,
config,
history,
Expand All @@ -416,6 +416,7 @@ export class PrebuildManager {
true,
);
if (prebuild) {
// TODO(gpl): Why not "done: prebuild.state === "available""?
return { prebuildId: prebuild.id, wsid: prebuild.buildWorkspaceId, done: true };
}
}
Expand Down
Loading
Loading