Fix GitHub Integration tests #20363
Merged
Fix GitHub Integration tests #20363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Nov 13, 2024
|
|
||
| @test public async testGetUserRepos() { | ||
| const result = await this.provider.getUserRepos(this.user); | ||
| expect(result).to.include({ url: "https://github.com/gitpod-io/gitpod", name: "gitpod" }); |
There was a problem hiding this comment.
GitHub seemingly only considers recent contributions, who knew!
filiptronicek
commented
Nov 13, 2024
| for (const type of ["contributedTo", "original", "forked"]) { | ||
| const nodes = result.data.viewer[type]?.nodes; | ||
| if (nodes) { | ||
| repos = nodes.map((n: any): RepositoryInfo => { |
There was a problem hiding this comment.
This was actually a bug where we always rewrote the existing array if there were nodes for a type. Unlucky for us, even if there weren't, empty JS arrays are truthy, so the repos would get overridden anyway.
filiptronicek
commented
Nov 13, 2024
| const result = await this.parser.handle( | ||
| {}, | ||
| this.user, | ||
| "https://github.com/eclipse-theia/theia/tree/master/LICENSE", |
There was a problem hiding this comment.
The file disappeared, so we had to update it.
mustard-mh
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Thank you @filiptronicek
$ yarn build && yarn mocha 'dist/github/**/*.spec.js' --exclude './node_modules/**' --exit
...
TestFileProvider
GitHub request took 227 ms
✔ testFileContent (228ms)
TestGithubContextRepositoryProvider
✔ testFetchCommitHistory (280ms)
✔ testGetUserRepos (241ms)
29 passing (8s)
Done in 8.80s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like we haven't run these in a while (at least a year and a half), and they needed some love. This PR provides that love.
How to test
Run the GitHub integrations tests in
serverThe token is in 1Password.
Related issue(s)
Fixes CLC-930
/hold