Fix Bitbucket Server repository provider tests #20364
Merged
+45
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furisto
approved these changes
Nov 13, 2024
filiptronicek
commented
Nov 13, 2024
|
|
||
| const commits = commitsResult.values || []; | ||
| return commits.map((c) => c.id); | ||
| return commits.map((c) => c.id).slice(1); |
There was a problem hiding this comment.
This is the place we change behavior. AFAIK, it did not cause any issues. This is because when we had checks checking things about each historical revision (like if there exists a prebuild for it), we just failed to find a prebuild twice instead of only once.
This way, the only impacted feature was our configurable prebuilds interval, which must've been off by one this whole time.
geropl
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests still targetted our old self-hosted instance and had some inconsistencies with actual current behavior.
Additionally, this PR fixes a bug with the
getCommitHistorymethod, which wrongly included the current commit as part of the history (this was the only SCM provider left for which we didn't skip the requested revision in the response).Related Issue(s)
Fixes CLC-932
How to test
/hold