Properly time out gp open
#20378
Properly time out gp open
#20378
Conversation
|
|
||
| if wait { | ||
| pargs = append(pargs, "--wait") | ||
| ctx = cmd.Context() |
There was a problem hiding this comment.
nit: there're ctx used before this line, like client.WaitForIDEReady(ctx). If a use passed --wait flag, it will not wait IDE to be ready after '10 seconds of not ready' then returns an error.
(But the original code has this issue as well, so I'm not sure if this is an intended feature)
There was a problem hiding this comment.
@mustard-mh looking at the code again, it seems fine to use the timeout-enabled context everywhere besides the final call to the editor binary, since we want to be able to time out on the other operations that are not expected to run potentially indefinitely.
Running the following inside the gitpod-cli directory seems to behave as expected, even when taking more than 10s to close the file:
go run . open --wait main.go 
Description
Make sure we don't hang too long when opening files. This can for instance happen when you've got the workspace open in both browser and desktop and supervisor is trying to open it in the editor you don't have in focus.
Related Issue(s)
Fixes https://gitpod.slack.com/archives/C04JEP60Q9X/p1731952414858989?thread_ts=1731952175.327349&cid=C04JEP60Q9X
/hold