Fix SCM integration tests and run them on build #20379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Nov 20, 2024
| // ✓ test_getRepos_searchString_wildcards_are_not_supported (172ms) | ||
| } | ||
|
|
||
| @test async test_getRepos_searchString_single_char_is_ignored() { |
Member
Author
There was a problem hiding this comment.
This didn't really make sense to me as a test, because single chars are not ignored with BBS.
filiptronicek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the integration tests for all SCMs. Also adds the related tokens in our main build workflow, so that we run those integration tests on push.
Related Issue(s)
Fixes CLC-944
How to test
Let it build (pending Filip adding the tokens as GHA secrets)