Allow short search strings on new workspace page #20415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Dec 3, 2024
|
|
||
| const filteredRepos = useMemo(() => { | ||
| const repos = [suggestedQuery.data || [], searchQuery.data || [], flattenedConfigurations ?? []].flat(); | ||
| const repos = [suggestedQuery.data || [], flattenedConfigurations ?? [], searchQuery.data || []].flat(); |
There was a problem hiding this comment.
This is done to artificially boost the priority of imported repos vs SCM-provided results.
Every time I change this, I think about how much we need to get rid of it entirely and just let listSuggestedRepositories receive a search string, which will do all deduplication and ordering by itself.
geropl
reviewed
Dec 4, 2024
geropl
reviewed
Dec 4, 2024
geropl
reviewed
Dec 4, 2024
geropl
reviewed
Dec 4, 2024
components/dashboard/src/data/git-providers/search-repositories-query.ts
Outdated
Show resolved
Hide resolved
geropl
reviewed
Dec 4, 2024
Co-authored-by: Gero Posmyk-Leinemann <[email protected]>
geropl
approved these changes
Dec 4, 2024
Co-authored-by: Gero Posmyk-Leinemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to search for repos that are 1 or 2 characters in length by removing the "please type at least 3 characters to search" limit.
Related Issue(s)
Fixes CLC-945
Builds on top of investigations done in #20413
How to test