Skip to content

Cleanup AWS re:Invent notifications #20429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Cleanup AWS re:Invent notifications #20429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions components/dashboard/src/AppNotifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,62 +131,6 @@ const INVALID_BILLING_ADDRESS = (stripePortalUrl: string | undefined) => {
} as Notification;
};

const GENERAL_NOTIFICATION = (
id: string,
message: JSX.Element,
updateUser: (user: Partial<UserProtocol>) => Promise<User>,
eventName: string = "general_notification",
) => {
return {
id,
type: "info",
preventDismiss: true,
onClose: async () => {
let dismissSuccess = false;
try {
const updatedUser = await updateUser({
additionalData: {
profile: {
coachmarksDismissals: {
[id]: new Date().toISOString(),
},
},
},
});
dismissSuccess = !!updatedUser;
} catch (err) {
dismissSuccess = false;
} finally {
trackEvent("coachmark_dismissed", {
name: eventName,
success: dismissSuccess,
});
}
},
message,
} as Notification;
};

const AWS_REINVENT_NOTIFICATION = (updateUser: (user: Partial<UserProtocol>) => Promise<User>) => {
return GENERAL_NOTIFICATION(
"aws_reinvent_2024",
<span className="text-md">
<b>See you at re:Invent!</b> Book a demo with us, and join our developer productivity leaders roundtable
(limited tickets) |{" "}
<a
className="text-kumquat-ripe font-bold"
href="https://www.gitpod.io/aws-reinvent-24"
target="_blank"
rel="noreferrer"
>
Learn more
</a>
</span>,
updateUser,
"aws_reinvent_notification",
);
};

export function AppNotifications() {
const [topNotification, setTopNotification] = useState<Notification | undefined>(undefined);
const { user, loading } = useUserLoader();
Expand Down Expand Up @@ -219,10 +163,6 @@ export function AppNotifications() {
if (isGitpodIo() && !user?.profile?.coachmarksDismissals[GITPOD_FLEX_INTRODUCTION_COACHMARK_KEY]) {
notifications.push(GITPOD_FLEX_INTRODUCTION((u: Partial<UserProtocol>) => mutateAsync(u)));
}

if (isGitpodIo() && !user?.profile?.coachmarksDismissals["aws_reinvent_2024"]) {
notifications.push(AWS_REINVENT_NOTIFICATION((u: Partial<UserProtocol>) => mutateAsync(u)));
}
}

if (!ignore) {
Expand Down
Loading