Skip to content

[server] Fix workspace service's workspace ID validation #20468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

[server] Fix workspace service's workspace ID validation #20468

merged 1 commit into from
Dec 19, 2024

Conversation

@filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Dec 19, 2024 •
edited
Loading

Description

Fixes a regression from #20269 which resulted in treating requests against legacy workspace IDs as invalid ones.

Related Issue(s)

Fixes CLC-1055

How to test

Try doing a GetWorkspace with a UUIDv4 as the workspaceId.

/hold

@filiptronicek filiptronicek self-assigned this Dec 19, 2024
@filiptronicek filiptronicek marked this pull request as ready for review December 19, 2024 15:06
@filiptronicek filiptronicek requested review from a team as code owners December 19, 2024 15:06
geropl
geropl approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@filiptronicek
Copy link
Member Author

🥳

> curl 'https://ft-fix-wor6d723b0ce4.preview.gitpod-dev.com/public-api/gitpod.v1.WorkspaceService/GetWorkspace' -X POST [...] --data-raw '{"workspaceId": "73ba77f4-f4f2-4631-a178-a05fd25af34c" }'
{"code":"not_found","message":"Workspace 73ba77f4-f4f2-4631-a178-a05fd25af34c not found."}

@roboquat roboquat merged commit b29e06a into main Dec 19, 2024
46 checks passed
@roboquat roboquat deleted the ft/fix-workspace-service-id-matching branch December 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geropl geropl geropl approved these changes

Assignees

@filiptronicek filiptronicek

Labels

size/S team: team-enterprise team: team-experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filiptronicek @geropl @roboquat