[server] Don't block soft deletion rewinds in updateDeletionEligibilityTime

[filiptronicek]

Description

Reverts a behavior we introduced in #20271 that prevented shifting the deletionEligibilityTime of a workspace backwards. This was problematic because workspaces with git changes are meant to live twice as long, but this change it made it so that "any workspace that ever had git changes" lived twice as long.

Related Issue(s)

Fix CLC-1070

/hold

[filiptronicek]

Here's the relevant logs from server when I started a workspace, created a file (git change) and then removed it again (we see the deletion eligibility time jump form 2025/02/13 to 2025/02/27 and then back to the 13th).

{"component":"server","severity":"INFO","time":"2025-01-30T17:52:53.997Z","context":{"requestId":"fc32140e-f04b-4f29-8962-fa8e634eacb3","requestKind":"jsonrpc","requestMethod":"updateGitStatus","traceId":"","subjectId":"user_9314a52c-6454-47e6-9d78-0d0a475c5bcc","userId":"9314a52c-6454-47e6-9d78-0d0a475c5bcc","contextTimeMs":22.98247000016272,"workspaceId":"[redacted:md5:638cd60bcfd82e952a95fce8f5a8a414]","instanceId":"558bd9b1-5443-4bd2-8ddf-0705d511d845"},"message":"[updateDeletionEligibilityTime] Updating deletion eligibility time for regular workspace","payload":{"hasGitChanges":false,"timestamps":{"deletionEligibilityTime":"2025-02-13T17:52:53.997Z","instanceStartedTime":"2025-01-30T17:52:49.340Z","instanceCreationTime":"2025-01-30T17:52:46.555Z","workspaceCreationTime":"2025-01-30T17:52:46.488Z","lastActive":"2025-01-30T17:52:49.340Z"}}}
{"component":"server","severity":"INFO","time":"2025-01-30T17:53:44.001Z","context":{"requestId":"6c1d3da1-e1ce-49b8-82ac-94cfe9988ba5","requestKind":"jsonrpc","requestMethod":"updateGitStatus","traceId":"","subjectId":"user_9314a52c-6454-47e6-9d78-0d0a475c5bcc","userId":"9314a52c-6454-47e6-9d78-0d0a475c5bcc","contextTimeMs":30.784508999902755,"workspaceId":"[redacted:md5:638cd60bcfd82e952a95fce8f5a8a414]","instanceId":"558bd9b1-5443-4bd2-8ddf-0705d511d845"},"message":"[updateDeletionEligibilityTime] Updating deletion eligibility time for regular workspace","payload":{"hasGitChanges":1,"timestamps":{"deletionEligibilityTime":"2025-02-27T17:53:44.001Z","instanceStartedTime":"2025-01-30T17:52:49.340Z","instanceCreationTime":"2025-01-30T17:52:46.555Z","workspaceCreationTime":"2025-01-30T17:52:46.488Z","lastActive":"2025-01-30T17:52:49.340Z"}}}
{"component":"server","severity":"INFO","time":"2025-01-30T17:53:53.997Z","context":{"requestId":"f44814e3-532b-4e18-9f67-f993074e7040","requestKind":"jsonrpc","requestMethod":"updateGitStatus","traceId":"","subjectId":"user_9314a52c-6454-47e6-9d78-0d0a475c5bcc","userId":"9314a52c-6454-47e6-9d78-0d0a475c5bcc","contextTimeMs":26.760228999890387,"workspaceId":"[redacted:md5:638cd60bcfd82e952a95fce8f5a8a414]","instanceId":"558bd9b1-5443-4bd2-8ddf-0705d511d845"},"message":"[updateDeletionEligibilityTime] Updating deletion eligibility time for regular workspace","payload":{"hasGitChanges":false,"timestamps":{"deletionEligibilityTime":"2025-02-13T17:53:53.997Z","instanceStartedTime":"2025-01-30T17:52:49.340Z","instanceCreationTime":"2025-01-30T17:52:46.555Z","workspaceCreationTime":"2025-01-30T17:52:46.488Z","lastActive":"2025-01-30T17:52:49.340Z"}}}

[geropl]

Code LGTM if this comment is addressed. ✔️