-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[docker-up] Auto-login dockerd if GITPOD_IMAGE_AUTH is set #20586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
…file if passed into workspace Tool: gitpod/catfood.gitpod.cloud
…xpose it on the API Tool: gitpod/catfood.gitpod.cloud
…s/env vars Tool: gitpod/catfood.gitpod.cloud
733089f to
95b33e8
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Had one blocking comment I left regarding permissions on Slack and some non-blocking ones.
I couldn't get the preview environment to load now, so couldn't test the end-to-end dockerd integration, hence this is just a code review.
components/dashboard/src/repositories/detail/variables/EnableDockerdAuthentication.tsx
Outdated
Show resolved
Hide resolved
…ite_settings permission Tool: gitpod/catfood.gitpod.cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. Feel free to unhold after looking at the rest of the review comments I left 🚀
Tool: gitpod/catfood.gitpod.cloud
667c645 to
ed278f9
Compare
|
/unhold |
Description
So far GITPOD_IMAGE_AUTH had two issues:
This PR fixes both issues, by introducing a project-level opt-in toggle to enable auto-login of
dockerdifGITPOD_IMAGE_AUTHis specified.Related Issue(s)
Fixes CLC-1098
Docs PR: https://github.com/gitpod-io/website/pull/5170
Prior PRs:
How to test
env | grep GITPOD_IMAGE_AUTHis not empty ✔️docker pull geropl/workspace-base-3:latest"just works" ™️ ✔️.gitpod.ymltoimage: geropl/workspace-base-3:latestgp validateand note how it successfully pulls the base image ✔️Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold