Skip to content

[ws-manager-mk2] always update workspace pod ip #20830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

[ws-manager-mk2] always update workspace pod ip #20830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions components/ws-manager-mk2/controllers/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,12 @@ func (r *WorkspaceReconciler) updateWorkspaceStatus(ctx context.Context, workspa
if workspace.Status.Runtime.HostIP == "" && pod.Status.HostIP != "" {
workspace.Status.Runtime.HostIP = pod.Status.HostIP
}
if workspace.Status.Runtime.PodIP == "" && pod.Status.PodIP != "" {
workspace.Status.Runtime.PodIP = pod.Status.PodIP
}
if workspace.Status.Runtime.PodName == "" && pod.Name != "" {
workspace.Status.Runtime.PodName = pod.Name
}

workspace.Status.Runtime.PodIP = pod.Status.PodIP

// Check if the node has disappeared. If so, ws-daemon has also disappeared and we need to
// mark the workspace backup as failed if it didn't complete disposal yet.
// Otherwise, the workspace will be stuck in the Stopping phase forever.
Expand Down
Loading