[image-builder] Avoid returning "Unknown" #20854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/1332-grpc-unknown
branch
from
0b0e904 to
d43daca
Compare
… avoid name clashes with the original service Also, avoid sending "Unknown" errors, and wrap it into meaningfull gRPC status codes (+ additional logging)
geropl
force-pushed
the
gpl/1332-grpc-unknown
branch
from
d43daca to
7196c9b
Compare
geropl
commented
May 30, 2025
| }{ | ||
| // Normal cases | ||
| { | ||
| name: "basic service with single dot", |
There was a problem hiding this comment.
Cline might have gone a little overboard with these test cases - but it's good to have it anyway 😅
corneliusludmann
approved these changes
Jun 2, 2025
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far image-builder seems to return "Unknown" to almost all "Build" requests. This PR addressed this by:
image-builder-mk3: Avoid returning "Unknown" in error cases, especially when the client terminated the streamws-manager-mk2: Avoid returning "Unknown" when client terminated the stream (and add logging for other cases)ws-manager-mk2: Prefix gRPC package name withproxied.so upstream metrics/alerting can properly filter out by prefix/nameRelated Issue(s)
Fixes CLC-1332
How to test
login https://gpl-1332-gf9b1d02de8.preview.gitpod-dev.com/workspaces
start workspace on a context that needs image building, e.g. https://github.com/geropl/gitpod-test-repo/tree/gpl/docker-build-30s (you need to bump the number there)
In another terminal, do
kubectl -n monitoring-satellite port-forward grafana-<tab> 3000In grafana, verify that the emitted metrics never container "Unknown" with
grpc_server_handled_total{grpc_method="Build"}Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold