[image-builder] Introduce retry for all resolver requests (timeout 15s, up to 3 times) for all network-related issues #20868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/1367-resolve
branch
2 times, most recently
from
67b9f5f to
7b1c075
Compare
github-actions
bot
added
team: team-experience
team: team-engine
team: team-enterprise
labels
geropl
commented
Jun 4, 2025
geropl
commented
Jun 4, 2025
iQQBot
reviewed
Jun 4, 2025
…esolved on startup [image-builder] Drop superfluous imports [image-builder] Switch to github.com/hashicorp/go-retryablehttp, incl. better unit tests at orchestrator level!
geropl
commented
Jun 5, 2025
iQQBot
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
using network policy blocked all egress for image-builder-mk3, it can actually retry, and final failed with several times retry.
and then restart a new workspace, during retry, I deleted the network policy, retry actually works, image build start successfully.
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses a custom RoundTripper for Resolve calls which:
Enabled with feature flag
imagebuilder_retry_resolveLooking for an in-depth code review, to pick up any issues I did not see 🙏
Related Issue(s)
Fixes CLC-1367
How to test
kubectl logs image-builder-mk3-789d87d65c-k7k77 -f | grep useRetryClientuseRetryClient: trueduring image build ✔️Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold