Skip to content

Conversation

@geropl
Copy link
Member

@geropl geropl commented Jun 6, 2025

Description

We do retries when doing HTTP requests. But if an error occurs while copying the response body, we did not re-establish the connection so far. This PR justs does this, as well as extending the backoff time span to ~10s instead of 1s, to be able to cover intermittent network problems.

Related Issue(s)

Fixes CLC-1416

How to test

  • new tests are green: ✔️
  • start a workspace ✔️
  • start an image build: ✔️

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid fix for the network retry issue, good test coverage

@geropl
Copy link
Member Author

geropl commented Jun 6, 2025

/unhold

@roboquat roboquat merged commit 6428470 into main Jun 6, 2025
49 checks passed
@roboquat roboquat deleted the gpl/195-registry-err branch June 6, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants