fix: prevent XSS in returnToPath parameter by validating protocol #20965
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returnToPath parameter validation was vulnerable to XSS attacks using javascript: protocol URLs with matching hostnames (e.g., javascript://gitpod.io/). This fix ensures only HTTPS URLs with matching hostnames are trusted. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a DOM XSS vulnerability in the
returnToPathparameter validation. The vulnerability allowed attackers to bypass security checks using javascript: protocol URLs with matching hostnames (e.g.,javascript://gitpod.io/%250a{{malicious code}}).The fix adds protocol validation to ensure only HTTPS URLs with matching hostnames are trusted.
Related Issue(s)
Fixes #CLC-1594
How to test
/login?returnToPath=javascript://gitpod.io/%250aalert(1)
/login?returnToPath=/workspaces/login?returnToPath=https://gitpod.io/dashboardcd components/dashboard && npm test -- src/utils.test.tsDocumentation
No documentation changes required - this is a security fix that doesn't change user-facing functionality.
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled.