Fix update-image-digest workflow missing token #21231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove explicit token parameter that referenced a missing secret. The workflow will use the default GITHUB_TOKEN instead. Add instructions for reviewers to trigger workflow checks after approval. Co-authored-by: Ona <[email protected]>
kylos101
had a problem deploying
to
branch-build
GitHub Actions
Failure
Co-authored-by: Ona <[email protected]>
Contributor
Author
|
@geropl closing for now (the default token lacks perms to create branches). Am thinking another way to automate could be with Ona automations...or like you mentioned we just do this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
update-image-digest.ymlworkflow was failing becausesecrets.ROBOQUAT_AUTOMATIC_CHANGELOGis not available. This removes the explicit token parameter so the workflow uses the defaultGITHUB_TOKENinstead.Also adds instructions for reviewers to trigger workflow checks after approval, since PRs created by
GITHUB_TOKENdon't automatically trigger workflows.Related Issue(s)
Fixes CLC-2186
How to test
Documentation
No
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold