Merged
Conversation
- Remove inaccessible shfmt feature that was causing build failures - Specify exact runtime versions (Go 1.24, Node 18) for consistency - Move leeway installation from postStartCommand to Dockerfile for proper global dependency management - Add port forwarding configuration (8080, 3000, 9000) with descriptions - Create comprehensive automations file with development workflows: - install-deps: Download Go dependencies (auto-triggered) - build-leeway: Build main application (manual) - test: Run Go tests (manual) - lint: Run linter if available (manual) - Remove obsolete install-leeway.sh script Fixes dev container build failure and establishes proper development environment following Gitpod development setup guidelines.
akosyakov
commented
Jun 3, 2025
| "ghcr.io/devcontainers/features/aws-cli:1": {} | ||
| }, | ||
| "postStartCommand": "./.devcontainer/install-leeway.sh" | ||
| "forwardPorts": [8080, 3000, 9000], |
akosyakov
commented
Jun 3, 2025
| "ghcr.io/devcontainers/features/aws-cli:1": {}, | ||
| "ghcr.io/devcontainers/features/aws-cli:1": {} | ||
| }, | ||
| "postStartCommand": "./.devcontainer/install-leeway.sh" |
Member
Author
There was a problem hiding this comment.
we ask the maintainer install global tools in Dockerfile for caching, I do wonder whether it applies here
akosyakov
commented
Jun 3, 2025
| "ghcr.io/devcontainers/features/node:1": {}, | ||
| "ghcr.io/devcontainers/features/go:1": {}, | ||
| "ghcr.io/devcontainers/features/common-utils:2": {}, | ||
| "ghcr.io/devcontainers-contrib/features/shfmt:1": { |
Member
Author
There was a problem hiding this comment.
such feature did not exist, was a bug, the agent could not find shfmt usage in the repo, and dropped
aledbf
approved these changes
Jun 3, 2025
csweichel
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes dev container build failure and establishes proper development environment following Gitpod development setup guidelines.
Related Issue(s)
Fixes #
How to test
Documentation
/hold