Merged
Conversation
akosyakov
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the build reporting functionality by adding the build directory information to the package build reporting. The changes include:
PackageBuildStartedmethod signature in theReporterinterface to include the build directory path as a parameter.Reporterinterface to accommodate the new parameter.The main benefit is improved visibility into where each package is being built, which can be helpful for debugging and understanding the build process.
Related Issue(s)
How to test
The changes can be tested using the existing automated tests in
reporter_test.go, which have been updated to verify the new build directory reporting functionality. The tests verify that:Running
go test ./pkg/leeway/... -run TestConsoleReportershould pass and verify the changes.