Skip to content

Make builddir reporting beautiful#233

Merged
csweichel merged 1 commit intomainfrom
cw/better-report-builddir
Jun 6, 2025
Merged

Make builddir reporting beautiful#233
csweichel merged 1 commit intomainfrom
cw/better-report-builddir

Conversation

@csweichel
Copy link
Collaborator

Description

This PR enhances the build reporting functionality by adding the build directory information to the package build reporting. The changes include:

  1. Modified the PackageBuildStarted method signature in the Reporter interface to include the build directory path as a parameter.
  2. Moved the reporter notification code in the build process to occur after the build directory is created, allowing it to include the build directory information.
  3. Updated the console output to display the build directory path alongside the version information.
  4. Updated all implementations of the Reporter interface to accommodate the new parameter.
  5. Updated tests to reflect these changes.

The main benefit is improved visibility into where each package is being built, which can be helpful for debugging and understanding the build process.

Related Issue(s)

How to test

The changes can be tested using the existing automated tests in reporter_test.go, which have been updated to verify the new build directory reporting functionality. The tests verify that:

  1. The build directory is correctly displayed in the console output
  2. The reporter interface correctly handles the new parameter
  3. All reporter implementations (Console, HTML, Composite, Noop) properly support the new parameter

Running go test ./pkg/leeway/... -run TestConsoleReporter should pass and verify the changes.

@csweichel csweichel merged commit f95417f into main Jun 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants