build(deps): revert containerd and runc bumps to fix v0.13.0 release#268
Closed
build(deps): revert containerd and runc bumps to fix v0.13.0 release#268
Conversation
Revert dependency bumps from PR #266 that caused build failures: - github.com/containerd/containerd v1.7.29 -> v1.7.26 - github.com/opencontainers/runc v1.2.8 -> v1.1.10 These versions are incompatible with Go 1.24.9 causing compilation errors. The bumps will be reintroduced when compatible versions are available. Fixes build error: cannot use limit (variable of type int64) as *int64 value in assignment Co-authored-by: Ona <no-reply@ona.com>
Contributor
Author
|
Closing this PR as the root cause analysis was incorrect. The issue is NOT with the dependencies ( The actual problem is the Go version in CI (1.24.0 vs 1.24.9). See #269 for the correct fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.13.0 release failed due to build errors caused by dependency bumps in PRs #260 and #261:
Root Cause
The bumped versions are incompatible with Go 1.24.9:
github.com/containerd/containerdv1.7.26 → v1.7.29github.com/opencontainers/runcv1.1.10 → v1.2.8These cause compilation errors due to type mismatches in the Go 1.24 toolchain.
Solution
Revert to the versions from v0.12.0:
github.com/containerd/containerd v1.7.26github.com/opencontainers/runc v1.1.10These versions build successfully and will allow the v0.13.0 release to proceed.
Testing
Next Steps
After this PR is merged, we can: