Fix two chat history bugs (microsoft#216848)

* Fix "show chats" before chat view is loaded
Fix microsoft/vscode-copilot-release#1079

* Fix microsoft/vscode-copilot-release#1327

Author: roblourens

src/vs/workbench/contrib/chat/browser/actions/chatActions.ts

@@ -15,13 +15,12 @@ import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
 import { IsLinuxContext, IsWindowsContext } from 'vs/platform/contextkey/common/contextkeys';
 import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry';
 import { IQuickInputButton, IQuickInputService, IQuickPickItem } from 'vs/platform/quickinput/common/quickInput';
-import { ViewAction } from 'vs/workbench/browser/parts/views/viewPane';
 import { CHAT_VIEW_ID, IChatWidgetService, showChatView } from 'vs/workbench/contrib/chat/browser/chat';
 import { IChatEditorOptions } from 'vs/workbench/contrib/chat/browser/chatEditor';
 import { ChatEditorInput } from 'vs/workbench/contrib/chat/browser/chatEditorInput';
 import { ChatViewPane } from 'vs/workbench/contrib/chat/browser/chatViewPane';
 import { ChatAgentLocation } from 'vs/workbench/contrib/chat/common/chatAgents';
-import { CONTEXT_CHAT_INPUT_CURSOR_AT_TOP, CONTEXT_CHAT_LOCATION, CONTEXT_IN_CHAT_INPUT, CONTEXT_IN_CHAT_SESSION, CONTEXT_CHAT_ENABLED } from 'vs/workbench/contrib/chat/common/chatContextKeys';
+import { CONTEXT_CHAT_ENABLED, CONTEXT_CHAT_INPUT_CURSOR_AT_TOP, CONTEXT_CHAT_LOCATION, CONTEXT_IN_CHAT_INPUT, CONTEXT_IN_CHAT_SESSION } from 'vs/workbench/contrib/chat/common/chatContextKeys';
 import { IChatDetail, IChatService } from 'vs/workbench/contrib/chat/common/chatService';
 import { IChatRequestViewModel, IChatResponseViewModel, isRequestVM } from 'vs/workbench/contrib/chat/common/chatViewModel';
 import { IChatWidgetHistoryService } from 'vs/workbench/contrib/chat/common/chatWidgetHistoryService';
@@ -102,10 +101,9 @@ class OpenChatGlobalAction extends Action2 {
 	}
 }
 
-class ChatHistoryAction extends ViewAction<ChatViewPane> {
+class ChatHistoryAction extends Action2 {
 	constructor() {
 		super({
-			viewId: CHAT_VIEW_ID,
 			id: `workbench.action.chat.history`,
 			title: localize2('chat.history.label', "Show Chats..."),
 			menu: {
@@ -121,12 +119,11 @@ class ChatHistoryAction extends ViewAction<ChatViewPane> {
 		});
 	}
 
-	async runInView(accessor: ServicesAccessor, view: ChatViewPane) {
+	async run(accessor: ServicesAccessor) {
 		const chatService = accessor.get(IChatService);
 		const quickInputService = accessor.get(IQuickInputService);
 		const viewsService = accessor.get(IViewsService);
 		const editorService = accessor.get(IEditorService);
-		const items = chatService.getHistory();
 
 		const openInEditorButton: IQuickInputButton = {
 			iconClass: ThemeIcon.asClassName(Codicon.file),
@@ -140,25 +137,30 @@ class ChatHistoryAction extends ViewAction<ChatViewPane> {
 		interface IChatPickerItem extends IQuickPickItem {
 			chat: IChatDetail;
 		}
-		const picks: IChatPickerItem[] = items.map((i): IChatPickerItem => ({
-			label: i.title,
-			chat: i,
-			buttons: [
-				openInEditorButton,
-				deleteButton
-			]
-		}));
+
+		const getPicks = () => {
+			const items = chatService.getHistory();
+			return items.map((i): IChatPickerItem => ({
+				label: i.title,
+				chat: i,
+				buttons: [
+					openInEditorButton,
+					deleteButton
+				]
+			}));
+		};
+
 		const store = new DisposableStore();
 		const picker = store.add(quickInputService.createQuickPick<IChatPickerItem>());
 		picker.placeholder = localize('interactiveSession.history.pick', "Switch to chat");
-		picker.items = picks;
+		picker.items = getPicks();
 		store.add(picker.onDidTriggerItemButton(context => {
 			if (context.button === openInEditorButton) {
 				editorService.openEditor({ resource: ChatEditorInput.getNewEditorUri(), options: <IChatEditorOptions>{ target: { sessionId: context.item.chat.sessionId }, pinned: true } }, ACTIVE_GROUP);
 				picker.hide();
 			} else if (context.button === deleteButton) {
 				chatService.removeHistoryEntry(context.item.chat.sessionId);
-				picker.items = picks.filter(i => i !== context.item);
+				picker.items = getPicks();
 			}
 		}));
 		store.add(picker.onDidAccept(async () => {