Skip to content

Commit 1fa08d1

Browse files
authored
Revert "Restore notebook layout performance optimization (microsoft#172466)" (microsoft#175180)
This reverts commit 317f309. Fixes microsoft#175179 The root cause is that the grid view is still passing us bad positions. Will open new bug for this
1 parent 9cec725 commit 1fa08d1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1709,7 +1709,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
17091709
return this._scrollBeyondLastLine && !this.isEmbedded;
17101710
}
17111711

1712-
layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, position?: DOM.IDomPosition): void {
1712+
layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, _position?: DOM.IDomPosition): void {
17131713
if (!shadowElement && this._shadowElementViewInfo === null) {
17141714
this._dimension = dimension;
17151715
return;
@@ -1721,7 +1721,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
17211721
}
17221722

17231723
if (shadowElement) {
1724-
this.updateShadowElement(shadowElement, dimension, position);
1724+
this.updateShadowElement(shadowElement, dimension, /*position*/ undefined);
17251725
}
17261726

17271727
if (this._shadowElementViewInfo && this._shadowElementViewInfo.width <= 0 && this._shadowElementViewInfo.height <= 0) {
@@ -1750,7 +1750,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
17501750
this._overlayContainer.style.position = 'absolute';
17511751
this._overlayContainer.style.overflow = 'hidden';
17521752

1753-
this.layoutContainerOverShadowElement(dimension, position);
1753+
this.layoutContainerOverShadowElement(dimension, /*position*/ undefined);
17541754

17551755
if (this._webviewTransparentCover) {
17561756
this._webviewTransparentCover.style.height = `${dimension.height}px`;

0 commit comments

Comments
 (0)