Skip to content

Commit 2d7655c

Browse files
authored
Add Refactor.move and Refactor.inline to code action widget (microsoft#161134)
Fixes microsoft#158515 Also aligns the icon to be more consistent with how they are used: - Surround with snippets use snippet icon - All refactorings use the wrench icon - Remove custom color which was added to some refactorings but not others
1 parent 6c3e1f0 commit 2d7655c

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/vs/editor/contrib/codeAction/browser/codeActionMenu.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,12 @@ const uncategorizedCodeActionGroup = Object.freeze<CodeActionGroup>({ kind: Code
8686

8787
const codeActionGroups = Object.freeze<CodeActionGroup[]>([
8888
{ kind: CodeActionKind.QuickFix, title: localize('codeAction.widget.id.quickfix', 'Quick Fix...') },
89-
{ kind: CodeActionKind.Extract, title: localize('codeAction.widget.id.extract', 'Extract...'), icon: { codicon: Codicon.wrench } },
90-
{ kind: CodeActionKind.Convert, title: localize('codeAction.widget.id.convert', 'Convert...'), icon: { codicon: Codicon.zap, color: 'var(--vscode-editorLightBulbAutoFix-foreground)' } },
91-
{ kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With...'), icon: { codicon: Codicon.symbolArray } },
92-
{ kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action...'), icon: { codicon: Codicon.lightBulb, color: 'var(--vscode-editorLightBulb-foreground)' } },
89+
{ kind: CodeActionKind.RefactorExtract, title: localize('codeAction.widget.id.extract', 'Extract...'), icon: { codicon: Codicon.wrench } },
90+
{ kind: CodeActionKind.RefactorInline, title: localize('codeAction.widget.id.inline', 'Inline...'), icon: { codicon: Codicon.wrench } },
91+
{ kind: CodeActionKind.RefactorRewrite, title: localize('codeAction.widget.id.convert', 'Rewrite...'), icon: { codicon: Codicon.wrench } },
92+
{ kind: CodeActionKind.RefactorMove, title: localize('codeAction.widget.id.move', 'Move...'), icon: { codicon: Codicon.wrench } },
93+
{ kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With...'), icon: { codicon: Codicon.symbolSnippet } },
94+
{ kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action...'), icon: { codicon: Codicon.symbolFile } },
9395
uncategorizedCodeActionGroup,
9496
]);
9597

src/vs/editor/contrib/codeAction/browser/types.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ export class CodeActionKind {
1313
public static readonly Empty = new CodeActionKind('');
1414
public static readonly QuickFix = new CodeActionKind('quickfix');
1515
public static readonly Refactor = new CodeActionKind('refactor');
16-
public static readonly Extract = CodeActionKind.Refactor.append('extract');
17-
public static readonly Convert = CodeActionKind.Refactor.append('rewrite');
16+
public static readonly RefactorExtract = CodeActionKind.Refactor.append('extract');
17+
public static readonly RefactorInline = CodeActionKind.Refactor.append('inline');
18+
public static readonly RefactorMove = CodeActionKind.Refactor.append('move');
19+
public static readonly RefactorRewrite = CodeActionKind.Refactor.append('rewrite');
1820
public static readonly Source = new CodeActionKind('source');
1921
public static readonly SourceOrganizeImports = CodeActionKind.Source.append('organizeImports');
2022
public static readonly SourceFixAll = CodeActionKind.Source.append('fixAll');

0 commit comments

Comments
 (0)