Skip to content

Commit 2fe7c46

Browse files
authored
ignore invalid parameters (microsoft#160458)
1 parent 2c1aee6 commit 2fe7c46

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -373,9 +373,6 @@ export class ShellIntegrationAddon extends Disposable implements IShellIntegrati
373373
}
374374
}
375375
case VSCodeOscPt.SetMark: {
376-
if (args.length > 2) {
377-
return false;
378-
}
379376
this._createOrGetBufferMarkDetection(this._terminal).addMark(parseMarkSequence(args));
380377
return true;
381378
}

src/vs/workbench/contrib/terminal/test/browser/xterm/shellIntegrationAddon.test.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,6 @@ suite('ShellIntegrationAddon', () => {
240240
await writeP(xterm, '\x1b]633;SetMark;1;Hidden\x07');
241241
strictEqual(capabilities.has(TerminalCapability.BufferMarkDetection), true);
242242
});
243-
test('SetMark - invalid', async () => {
244-
strictEqual(capabilities.has(TerminalCapability.BufferMarkDetection), false);
245-
await writeP(xterm, 'foo');
246-
strictEqual(capabilities.has(TerminalCapability.BufferMarkDetection), false);
247-
await writeP(xterm, '\x1b]633;SetMark;;;\x07');
248-
strictEqual(capabilities.has(TerminalCapability.BufferMarkDetection), false);
249-
});
250243
suite('parseMarkSequence', () => {
251244
test('basic', async () => {
252245
deepEqual(parseMarkSequence(['', '']), { id: undefined, hidden: false });

0 commit comments

Comments
 (0)