Skip to content

Commit 4ded39c

Browse files
authored
Merge pull request microsoft#199988 from microsoft/merogge/hover-candy
ensure hover is focused if we show accessible view hint is included
2 parents 5884aa4 + b93fc21 commit 4ded39c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/vs/editor/contrib/hover/browser/contentHover.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -782,9 +782,9 @@ export class ContentHoverWidget extends ResizableContentWidget {
782782
this._hover.containerDomNode.focus();
783783
}
784784
hoverData.colorPicker?.layout();
785-
786785
// The aria label overrides the label, so if we add to it, add the contents of the hover
787-
const accessibleViewHint = getHoverAccessibleViewHint(this._configurationService.getValue('accessibility.verbosity.hover') === true && this._accessibilityService.isScreenReaderOptimized(), this._keybindingService.lookupKeybinding('editor.action.accessibleView')?.getAriaLabel() ?? '');
786+
const hoverFocused = this._hover.containerDomNode.ownerDocument.activeElement === this._hover.containerDomNode;
787+
const accessibleViewHint = hoverFocused && getHoverAccessibleViewHint(this._configurationService.getValue('accessibility.verbosity.hover') === true && this._accessibilityService.isScreenReaderOptimized(), this._keybindingService.lookupKeybinding('editor.action.accessibleView')?.getAriaLabel() ?? '');
788788
if (accessibleViewHint) {
789789
this._hover.contentsDomNode.ariaLabel = this._hover.contentsDomNode.textContent + ', ' + accessibleViewHint;
790790
}

src/vs/workbench/services/hover/browser/hoverWidget.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,8 @@ export class HoverWidget extends Widget {
302302

303303
public render(container: HTMLElement): void {
304304
container.appendChild(this._hoverContainer);
305-
const accessibleViewHint = getHoverAccessibleViewHint(this._configurationService.getValue('accessibility.verbosity.hover') === true && this._accessibilityService.isScreenReaderOptimized(), this._keybindingService.lookupKeybinding('editor.action.accessibleView')?.getAriaLabel());
305+
const hoverFocused = this._hoverContainer.contains(this._hoverContainer.ownerDocument.activeElement);
306+
const accessibleViewHint = hoverFocused && getHoverAccessibleViewHint(this._configurationService.getValue('accessibility.verbosity.hover') === true && this._accessibilityService.isScreenReaderOptimized(), this._keybindingService.lookupKeybinding('editor.action.accessibleView')?.getAriaLabel());
306307
if (accessibleViewHint) {
307308

308309
status(accessibleViewHint);

0 commit comments

Comments
 (0)