download the extensions locally while installing failed remote extensions from workbench (microsoft#241719)

Author: sandy081

src/vs/platform/extensionManagement/common/extensionManagement.ts

@@ -537,6 +537,7 @@ export type InstallOptions = {
 	installOnlyNewlyAddedFromExtensionPack?: boolean;
 	productVersion?: IProductVersion;
 	keepExisting?: boolean;
+	downloadExtensionsLocally?: boolean;
 	/**
 	 * Context passed through to InstallExtensionResult
 	 */

src/vs/workbench/contrib/extensions/electron-sandbox/remoteExtensionsInit.ts

@@ -59,14 +59,19 @@ export class InstallFailedRemoteExtensionsContribution implements IWorkbenchCont
 		for (const { id, installOptions } of failed) {
 			const extension = galleryExtensions.find(e => areSameExtensions(e.identifier, { id }));
 			if (extension) {
-				installExtensionInfo.push({ extension, options: installOptions });
+				installExtensionInfo.push({
+					extension, options: {
+						...installOptions,
+						downloadExtensionsLocally: true,
+					}
+				});
 			} else {
 				this.logService.warn(`Relayed failed extension '${id}' from server is not found in the gallery`);
 			}
 		}
 
 		if (installExtensionInfo.length) {
-			await this.extensionManagementServerService.remoteExtensionManagementServer.extensionManagementService.installGalleryExtensions(installExtensionInfo);
+			await Promise.allSettled(installExtensionInfo.map(e => this.extensionManagementServerService.remoteExtensionManagementServer!.extensionManagementService.installFromGallery(e.extension, e.options)));
 		}
 	}
 }

src/vs/workbench/services/extensionManagement/electron-sandbox/remoteExtensionManagementService.ts

@@ -64,7 +64,7 @@ export class NativeRemoteExtensionManagementService extends RemoteExtensionManag
 	}
 
 	private async doInstallFromGallery(extension: IGalleryExtension, installOptions: InstallOptions): Promise<ILocalExtension> {
-		if (this.configurationService.getValue('remote.downloadExtensionsLocally')) {
+		if (installOptions.downloadExtensionsLocally || this.configurationService.getValue('remote.downloadExtensionsLocally')) {
 			return this.downloadAndInstall(extension, installOptions);
 		}
 		try {