only adjust top when resizing if widget is rendered above (microsoft#241729)

meganrogge · web-flow · commit 87bf10ccb467 · 2025-02-24T19:01:40.000+01:00
fix microsoft#239030
diff --git a/src/vs/workbench/services/suggest/browser/simpleSuggestWidget.ts b/src/vs/workbench/services/suggest/browser/simpleSuggestWidget.ts
@@ -749,7 +749,7 @@ export class SimpleSuggestWidget<TModel extends SimpleCompletionModel<TItem>, TI
 
 		this._listElement.style.width = `${width}px`;
 		this.element.layout(height, width);
-		if (this._cursorPosition) {
+		if (this._cursorPosition && this._preference === WidgetPositionPreference.Above) {
 			this.element.domNode.style.top = `${this._cursorPosition.top - height}px`;
 		}
 		this._positionDetails();

Original file line number	Diff line number	Diff line change
`@@ -749,7 +749,7 @@ export class SimpleSuggestWidget<TModel extends SimpleCompletionModel<TItem>, TI`
`749`	`749`
`750`	`750`	this._listElement.style.width = `${width}px`;
`751`	`751`	`this.element.layout(height, width);`
`752`		`- if (this._cursorPosition) {`
	`752`	`+ if (this._cursorPosition && this._preference === WidgetPositionPreference.Above) {`
`753`	`753`	this.element.domNode.style.top = `${this._cursorPosition.top - height}px`;
`754`	`754`	`}`
`755`	`755`	`this._positionDetails();`