Warn about installed extensions that are no longer available in Marketplace (microsoft#248852)

* Display warning for unpublished gallery extensions

ref: microsoft#181248

* naming is hard

* tidy up

* update variable

* detect missing extension

* add a filter to 'syncMissingFromGallery' so we can compare against subsets of a galleryExtension

* move into syncInstalledExtensionsWithGallery

Author: joshspicer

src/vs/workbench/contrib/extensions/browser/extensionsActions.ts

@@ -2608,6 +2608,11 @@ export class ExtensionStatusAction extends ExtensionAction {
 			return;
 		}
 
+		if (this.extension.missingFromGallery) {
+			this.updateStatus({ icon: warningIcon, message: new MarkdownString(localize('missing from gallery tooltip', "This extension is no longer available on the Extension Marketplace.")) }, true);
+			return;
+		}
+
 		if (this.extensionsWorkbenchService.canSetLanguage(this.extension)) {
 			return;
 		}

src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts

@@ -95,6 +95,8 @@ export class Extension implements IExtension {
 
 	private galleryResourcesCache = new Map<string, any>();
 
+	private _missingFromGallery: boolean | undefined;
+
 	constructor(
 		private stateProvider: IExtensionStateProvider<ExtensionState>,
 		private runtimeStateProvider: IExtensionStateProvider<ExtensionRuntimeState | undefined>,
@@ -136,6 +138,14 @@ export class Extension implements IExtension {
 		this.galleryResourcesCache.clear();
 	}
 
+	get missingFromGallery(): boolean {
+		return !!this._missingFromGallery;
+	}
+
+	set missingFromGallery(missing: boolean) {
+		this._missingFromGallery = missing;
+	}
+
 	get type(): ExtensionType {
 		return this.local ? this.local.type : ExtensionType.User;
 	}
@@ -657,7 +667,7 @@ class Extensions extends Disposable {
 		return this.local;
 	}
 
-	async syncInstalledExtensionsWithGallery(galleryExtensions: IGalleryExtension[], productVersion: IProductVersion): Promise<void> {
+	async syncInstalledExtensionsWithGallery(galleryExtensions: IGalleryExtension[], productVersion: IProductVersion, flagExtensionsMissingFromGallery?: IExtensionInfo[]): Promise<void> {
 		const extensions = await this.mapInstalledExtensionWithCompatibleGalleryExtension(galleryExtensions, productVersion);
 		for (const [extension, gallery] of extensions) {
 			// update metadata of the extension if it does not exist
@@ -669,6 +679,23 @@ class Extensions extends Disposable {
 				this._onChange.fire({ extension });
 			}
 		}
+		// Detect extensions that do not have a corresponding gallery entry.
+		// This indicates that it was likely removed from the gallery
+		if (flagExtensionsMissingFromGallery) {
+			for (const extension of this.local) {
+				if (!extension.identifier.uuid) {
+					continue;
+				}
+				if (!flagExtensionsMissingFromGallery.some(f => areSameExtensions(f, extension.identifier))) {
+					continue;
+				}
+				const gallery = galleryExtensions.find(g => areSameExtensions(g.identifier, extension.identifier));
+				if (!gallery) {
+					extension.missingFromGallery = true;
+					this._onChange.fire({ extension });
+				}
+			}
+		}
 	}
 
 	private async mapInstalledExtensionWithCompatibleGalleryExtension(galleryExtensions: IGalleryExtension[], productVersion: IProductVersion): Promise<[Extension, IGalleryExtension][]> {
@@ -1874,7 +1901,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension
 			this.logService.trace(`Checking updates for extensions`, infos.map(e => e.id).join(', '));
 			const galleryExtensions = await this.galleryService.getExtensions(infos, { targetPlatform, compatible: true, productVersion: this.getProductVersion(), updateCheck: true }, CancellationToken.None);
 			if (galleryExtensions.length) {
-				await this.syncInstalledExtensionsWithGallery(galleryExtensions);
+				await this.syncInstalledExtensionsWithGallery(galleryExtensions, infos);
 			}
 		}
 	}
@@ -1981,7 +2008,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension
 		return pick?.id;
 	}
 
-	private async syncInstalledExtensionsWithGallery(gallery: IGalleryExtension[]): Promise<void> {
+	private async syncInstalledExtensionsWithGallery(gallery: IGalleryExtension[], flagExtensionsMissingFromGallery?: IExtensionInfo[]): Promise<void> {
 		const extensions: Extensions[] = [];
 		if (this.localExtensions) {
 			extensions.push(this.localExtensions);
@@ -1995,7 +2022,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension
 		if (!extensions.length) {
 			return;
 		}
-		await Promise.allSettled(extensions.map(extensions => extensions.syncInstalledExtensionsWithGallery(gallery, this.getProductVersion())));
+		await Promise.allSettled(extensions.map(extensions => extensions.syncInstalledExtensionsWithGallery(gallery, this.getProductVersion(), flagExtensionsMissingFromGallery)));
 		if (this.outdated.length) {
 			this.logService.info(`Auto updating outdated extensions.`, this.outdated.map(e => e.identifier.id).join(', '));
 			this.eventuallyAutoUpdateExtensions();

src/vs/workbench/contrib/extensions/common/extensions.ts

@@ -107,6 +107,7 @@ export interface IExtension {
 	readonly isMalicious: boolean | undefined;
 	readonly maliciousInfoLink: string | undefined;
 	readonly deprecationInfo?: IDeprecationInfo;
+	readonly missingFromGallery?: boolean;
 }
 
 export const IExtensionsWorkbenchService = createDecorator<IExtensionsWorkbenchService>('extensionsWorkbenchService');