Skip to content

Commit 8c3edc0

Browse files
authored
Update classification property comments (microsoft#155526)
1 parent 75f4d52 commit 8c3edc0

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

src/vs/workbench/browser/parts/editor/editorCommands.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -970,10 +970,10 @@ function registerCloseEditorCommands() {
970970
type WorkbenchEditorReopenClassification = {
971971
owner: 'rebornix';
972972
comment: 'Identify how a document is reopened';
973-
scheme: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
974-
ext: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
975-
from: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
976-
to: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
973+
scheme: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'File system provider scheme for the resource' };
974+
ext: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'File extension for the resource' };
975+
from: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The editor view type the resource is switched from' };
976+
to: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The editor view type the resource is switched to' };
977977
};
978978

979979
type WorkbenchEditorReopenEvent = {

src/vs/workbench/contrib/notebook/browser/notebookEditor.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -245,14 +245,14 @@ export class NotebookEditor extends EditorPane implements IEditorPaneWithSelecti
245245
type WorkbenchNotebookOpenClassification = {
246246
owner: 'rebornix';
247247
comment: 'The notebook file open metrics. Used to get a better understanding of the performance of notebook file opening';
248-
scheme: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
249-
ext: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
250-
viewType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
251-
extensionActivated: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
252-
inputLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
253-
webviewCommLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
254-
customMarkdownLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
255-
editorLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
248+
scheme: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'File system provider scheme for the notebook resource' };
249+
ext: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'File extension for the notebook resource' };
250+
viewType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The view type of the notebook editor' };
251+
extensionActivated: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Extension activation time for the resource opening' };
252+
inputLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Editor Input loading time for the resource opening' };
253+
webviewCommLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Webview initialization time for the resource opening' };
254+
customMarkdownLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Custom markdown loading time for the resource opening' };
255+
editorLoaded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Overall editor loading time for the resource opening' };
256256
};
257257

258258
type WorkbenchNotebookOpenEvent = {

src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1102,9 +1102,9 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
11021102
type WorkbenchNotebookOpenClassification = {
11031103
owner: 'rebornix';
11041104
comment: 'Identify the notebook editor view type';
1105-
scheme: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
1106-
ext: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
1107-
viewType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
1105+
scheme: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'File system provider scheme for the resource' };
1106+
ext: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'File extension for the resource' };
1107+
viewType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'View type of the notebook editor' };
11081108
};
11091109

11101110
type WorkbenchNotebookOpenEvent = {

0 commit comments

Comments
 (0)