Prefer that quotes terminate links in ambiguous cases (microsoft#164431)

Fixes microsoft#156875: Prefer that quotes terminate links in ambiguous cases

Author: alexdima

src/vs/editor/common/languages/linkComputer.ts

@@ -258,15 +258,19 @@ export class LinkComputer {
 						case CharCode.CloseCurlyBrace:
 							chClass = (hasOpenCurlyBracket ? CharacterClass.None : CharacterClass.ForceTermination);
 							break;
-						/* The following three rules make it that ' or " or ` are allowed inside links if the link didn't begin with them */
+
+						// The following three rules make it that ' or " or ` are allowed inside links
+						// only if the link is wrapped by some other quote character
 						case CharCode.SingleQuote:
-							chClass = (linkBeginChCode === CharCode.SingleQuote ? CharacterClass.ForceTermination : CharacterClass.None);
-							break;
 						case CharCode.DoubleQuote:
-							chClass = (linkBeginChCode === CharCode.DoubleQuote ? CharacterClass.ForceTermination : CharacterClass.None);
-							break;
 						case CharCode.BackTick:
-							chClass = (linkBeginChCode === CharCode.BackTick ? CharacterClass.ForceTermination : CharacterClass.None);
+							if (linkBeginChCode === chCode) {
+								chClass = CharacterClass.ForceTermination;
+							} else if (linkBeginChCode === CharCode.SingleQuote || linkBeginChCode === CharCode.DoubleQuote || linkBeginChCode === CharCode.BackTick) {
+								chClass = CharacterClass.None;
+							} else {
+								chClass = CharacterClass.ForceTermination;
+							}
 							break;
 						case CharCode.Asterisk:
 							// `*` terminates a link if the link began with `*`

src/vs/editor/test/common/modes/linkComputer.test.ts

@@ -259,10 +259,18 @@ suite('Editor Modes - Link Computer', () => {
 		);
 	});
 
-	test('issue #151631: Link parsing stoped where comments include a single quote ', () => {
-		assertLink(
-			`aa https://regexper.com/#%2F''%2F aa`,
-			`   https://regexper.com/#%2F''%2F   `,
+	// Removed because of #156875
+	// test('issue #151631: Link parsing stoped where comments include a single quote ', () => {
+	// 	assertLink(
+	// 		`aa https://regexper.com/#%2F''%2F aa`,
+	// 		`   https://regexper.com/#%2F''%2F   `,
+	// 	);
+	// });
+
+	test('issue #156875: Links include quotes ', () => {
+		assertLink(
+			`"This file has been converted from https://github.com/jeff-hykin/better-c-syntax/blob/master/autogenerated/c.tmLanguage.json",`,
+			`                                   https://github.com/jeff-hykin/better-c-syntax/blob/master/autogenerated/c.tmLanguage.json  `,
 		);
 	});
 });