fix: dismiss stuck if field polluted (microsoft#223423)

rzhao271 · web-flow · commit d05710b3924d · 2024-07-23T16:19:31.000-07:00
diff --git a/src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts b/src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
@@ -710,11 +710,9 @@ export class SettingsEditor2 extends EditorPane {
 	}
 
 	private onDidDismissExtensionSetting(extensionId: string): void {
-		if (this.dismissedExtensionSettings.includes(extensionId)) {
-			return;
+		if (!this.dismissedExtensionSettings.includes(extensionId)) {
+			this.dismissedExtensionSettings.push(extensionId);
 		}
-
-		this.dismissedExtensionSettings.push(extensionId);
 		this.storageService.store(
 			this.DISMISSED_EXTENSION_SETTINGS_STORAGE_KEY,
 			this.dismissedExtensionSettings.join(this.DISMISSED_EXTENSION_SETTINGS_DELIMITER),

Original file line number	Diff line number	Diff line change
`@@ -710,11 +710,9 @@ export class SettingsEditor2 extends EditorPane {`
`710`	`710`	`}`
`711`	`711`
`712`	`712`	`private onDidDismissExtensionSetting(extensionId: string): void {`
`713`		`- if (this.dismissedExtensionSettings.includes(extensionId)) {`
`714`		`- return;`
	`713`	`+ if (!this.dismissedExtensionSettings.includes(extensionId)) {`
	`714`	`+ this.dismissedExtensionSettings.push(extensionId);`
`715`	`715`	`}`
`716`		`-`
`717`		`- this.dismissedExtensionSettings.push(extensionId);`
`718`	`716`	`this.storageService.store(`
`719`	`717`	`this.DISMISSED_EXTENSION_SETTINGS_STORAGE_KEY,`
`720`	`718`	`this.dismissedExtensionSettings.join(this.DISMISSED_EXTENSION_SETTINGS_DELIMITER),`